Skip to content

Add PodDashboardInventoryCard component #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mareklibra wants to merge 1 commit into from
Closed

Add PodDashboardInventoryCard component #2833

mareklibra wants to merge 1 commit into from

Conversation

@mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Sep 25, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/core Related to console core functionality component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Sep 25, 2019
@spadgett spadgett changed the base branch from master-4.3 to master September 25, 2019 20:04
@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 4, 2019

Rebased

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mareklibra
To complete the pull request process, please assign jhadvig
You can assign the PR to them by writing /assign @jhadvig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rawagner
rawagner suggested changes Oct 4, 2019
View reviewed changes
frontend/public/components/pod-dashboard-inventory.tsx Outdated
<DashboardCardHeader>
<DashboardCardTitle>Inventory</DashboardCardTitle>
</DashboardCardHeader>
<DashboardCardBody isLoading={isLoading}>
Copy link
Contributor

@rawagner rawagner Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this loading is not needed as you have loadings for specific inventory items

Copy link
Contributor Author

@mareklibra mareklibra Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 8, 2019

/retest

1 similar comment
@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 8, 2019

/retest

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 8, 2019

/assign @jhadvig

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 9, 2019

@spadgett , @andybraren , IIUC the Pod Dashboard will probably be descoped for 4.3 and redesigned.

Anyway, this PR is ready based on former design. Would it make sense to land it and make the changes once the new design will exist?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2019

@mareklibra: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 13c102f link /test e2e-gcp
ci/prow/e2e-gcp-console 13c102f link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 22, 2019

The pod-dashboard has been descoped for 4.2.

@mareklibra mareklibra closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andybraren andybraren Awaiting requested review from andybraren

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

1 more reviewer

@rawagner rawagner rawagner requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jhadvig jhadvig

Labels

component/core Related to console core functionality component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mareklibra @openshift-ci-robot @rawagner @jhadvig